Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support price range in alipay/wechat providers #131

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

Triple-Z
Copy link
Member

Description

resolves #129

Motivation and Context

#129

Dependencies

None

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

make test

Is this change properly documented?

Yes.

@Triple-Z Triple-Z requested review from gaocegege and a team as code owners September 15, 2024 09:22
@Triple-Z
Copy link
Member Author

This feature's 80% code is written by Cursor, and I am amazed by its tremendous performance.

Copy link
Contributor

@ramsayleung ramsayleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a few comments with questions, let me know whether the questions I mention are by design.

README.md Show resolved Hide resolved
pkg/analyser/wechat/wechat.go Show resolved Hide resolved
pkg/analyser/wechat/wechat.go Show resolved Hide resolved
Signed-off-by: TripleZ <[email protected]>
Copy link
Contributor

@ramsayleung ramsayleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, thanks for your great work.

Happy Mid-Autumn Festival :) (if you are in the UTC+8 timezone)

README.md Show resolved Hide resolved
@Triple-Z Triple-Z merged commit ef964f3 into master Sep 17, 2024
4 checks passed
@Triple-Z Triple-Z deleted the feat-match-rule-price branch September 17, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

匹配规则支持金额
2 participants