-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 增加对海外银行 bmo provider 的支持 #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
double-entry-generator
增加对海外银行BMO
的账单支持BMO
BMO
是加拿大的五大银行之一, 与 TD 齐名, 主要业务在加拿大.Transaction Statement
Debit
BMO的存储卡账单相当简洁 (
简陋), 只有5个字段:Peer
) 和 商品(Item
)字段, 都合并在 Transaction Description, 因此将Transaction Description
当作Item
字段,Peer
字段为TD
Credit
信用卡账单更简单,有用的字段只有3个, 通过金额正负来判断交易方向.
Modification
example/bmo
: 增加bmo 相关的配置, 生成账单analyser/bmo
:analyser
增加bmo
相关内容provider/bmo
: 增加bmo
provider
test
: 增加bmo
相关test我尽量提交最少修改的PR, 但是新增一个 workable
provider
以及相应test
,example
的改动量着实较大, 见谅见谅Motivation and Context
#112
Dependencies
None
Type of change
Please delete options that are not relevant.
How has this been tested?
sh test/bmo-test-beancount.sh
: passedsh test/bmo-test-ledger.sh
: passedmake test
: all tests passedIs this change properly documented?
Please make sure you've properly documented the changes you're making.
Don't forget to add an entry to the CHANGELOG/README if necessary (new features, breaking changes, relevant internal improvements).
后续提另外的PR更新README.