ui/network: add error handling for refreshFinished (commaai#32167)

deanlee · Apr 25, 2024 · 3bcb6f8 · 3bcb6f8
1 parent 06c4a54
commit 3bcb6f8
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/selfdrive/ui/qt/network/wifi_manager.cc b/selfdrive/ui/qt/network/wifi_manager.cc
@@ -99,10 +99,20 @@ void WifiManager::refreshFinished(QDBusPendingCallWatcher *watcher) {
   seenNetworks.clear();
 
   const QDBusReply<QList<QDBusObjectPath>> watcher_reply = *watcher;
+  if (!watcher_reply.isValid()) {
+    qCritical() << "Failed to refresh";
+    watcher->deleteLater();
+    return;
+  }
+
   for (const QDBusObjectPath &path : watcher_reply.value()) {
     QDBusReply<QVariantMap> reply = call(path.path(), NM_DBUS_INTERFACE_PROPERTIES, "GetAll", NM_DBUS_INTERFACE_ACCESS_POINT);
-    auto properties = reply.value();
+    if (!reply.isValid()) {
+      qCritical() << "Failed to retrieve properties for path:" << path.path();
+      continue;
+    }
 
+    auto properties = reply.value();
     const QByteArray ssid = properties["Ssid"].toByteArray();
     if (ssid.isEmpty()) continue;