use a sha256 instead of base64

dealnews · Sep 5, 2024 · 2fd207d · 2fd207d
1 parent 2ae10b0
commit 2fd207d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/TmpDir.php b/src/TmpDir.php
@@ -17,9 +17,9 @@ public function tmpDir(?string $base_dir = null): string {
 
         do {
             $success = false;
-            $dir = $base_dir . '/' . base64_encode(random_bytes(32));
+            $dir = $base_dir . '/' . hash('sha256', (random_bytes(32)));
             if (!file_exists($dir)) {
-                $success = mkdir($dir);
+                $success = mkdir($dir, recursive: true);
             }
         } while (!$success);
 

diff --git a/tests/TmpDirTest.php b/tests/TmpDirTest.php
@@ -15,7 +15,7 @@ public function testTmpDir() {
 
         $dir2 = $this->tmpDir($dir);
 
-        $this->assertTrue(is_dir($dir));
+        $this->assertTrue(is_dir($dir2));
 
         rmdir($dir2);
         rmdir($dir);