Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some headway on #18 - when interpolating points along the cube edges we bailed early if v1 or v2 was close to zero. However, if both v1 and v2 are close to zero then picking one or the other point means we might get unstable results depending on the order in which edges are evaluated.
This PR proposes to pick the midpoint between the two edges if there's no meaningful difference between the SDF values at the respective endpoints. Together with the script posted in #18 this helps with single-incident edges:
bottom-octtree.stl before:
bottom-octtree.stl after: