fix(rescue_instance): added tests

[qqmok]

@dweinholz

Try to fulfill the following points before the Pull Request is merged:

• The PR is reviewed by one of the team members.
• If a linting PR exists, it must be merged before this PR is allowed to be merged.
• If the PR is merged in the master then a release should be be made.
• If the new code is readable, if not it should be well commented

For releases only:

• If the review of this PR is approved and the PR is followed by a release then the .env file
  in the cloud-portal repo should also be updated.
• If you are making a release then please sum up the changes since the last release on the release page using the clog tool with clog -F

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
simple_vm_client
VirtualMachineHandler.py	198	15	15	92%
__init__.py	1	0	100%
test_virtualmachinehandler.py	303	0	100%
simple_vm_client/benchmark
__init__.py	0	0	100%
test_service.py	52	36	36	31%
simple_vm_client/bibigrid_connector
__init__.py	0	0	100%
bibigrid_connector.py	118	5	5	96%
test_bibigrid_connector.py	173	0	100%
simple_vm_client/forc_connector
__init__.py	0	0	100%
forc_connector.py	252	4	4	98%
simple_vm_client/forc_connector/playbook
__init__.py	0	0	100%
playbook.py	191	0	100%
test_playbook.py	381	0	100%
simple_vm_client/forc_connector/template
__init__.py	0	0	100%
template.py	195	1	1	99%
simple_vm_client/metadata_connector
metadata_connector.py	88	71	71	19%
simple_vm_client/openstack_connector
__init__.py	0	0	100%
openstack_connector.py	932	121	121	87%
simple_vm_client/util
__init__.py	0	0	100%
state_enums.py	69	0	100%
test_thrift_converter.py	170	0	100%
thrift_converter.py	80	14	14	82%
TOTAL	3203	267	92%

Tests	Skipped	Failures	Errors	Time
306	0 💤	0 ❌	0 🔥	4.822s ⏱️

[dweinholz]

When running the tests via:
python3-coverage run -m unittest discover -s .

All rescue tests are failing

[vktrrdk]

One coverage test is still failing:

2024-11-26 08:24:08,678 - Clearing traces of Playbook-VM for (openstack_id): c
....F..................2024-11-26 08:24:08 - [ERROR] - [/home/ubuntu/code/simplevm-client/simple_vm_client/util/thrift_converter.py:os_to_thrift_volume:74] - Exception on os_to_thrift_volume:
string indices must be integers
2024-11-26 08:24:08,855 - Exception on os_to_thrift_volume:
string indices must be integers
.......

FAIL: test_rescue_server (simple_vm_client.test_virtualmachinehandler.TestVirtualMachineHandler)

Traceback (most recent call last):
File "/home/ubuntu/code/simplevm-client/simple_vm_client/test_virtualmachinehandler.py", line 168, in test_rescue_server
self.handler.openstack_connector.rescue_server.assert_called_once_with(
File "/usr/lib/python3.10/unittest/mock.py", line 941, in assert_called_once_with
return self.assert_called_with(*args, **kwargs)
File "/usr/lib/python3.10/unittest/mock.py", line 929, in assert_called_with
raise AssertionError(_error_message()) from cause
AssertionError: expected call not found.
Expected: rescue_server(openstack_id='vm_id')
Actual: rescue_server(openstack_id='vm_id', admin_pass=None, image_ref=None)

---

Ran 306 tests in 3.103s

FAILED (failures=1)

[qqmok]

One coverage test is still failing:

2024-11-26 08:24:08,678 - Clearing traces of Playbook-VM for (openstack_id): c

....F..................2024-11-26 08:24:08 - [ERROR] - [/home/ubuntu/code/simplevm-client/simple_vm_client/util/thrift_converter.py:os_to_thrift_volume:74] - Exception on os_to_thrift_volume:
string indices must be integers
2024-11-26 08:24:08,855 - Exception on os_to_thrift_volume:
string indices must be integers
.......

FAIL: test_rescue_server (simple_vm_client.test_virtualmachinehandler.TestVirtualMachineHandler)

Traceback (most recent call last): File "/home/ubuntu/code/simplevm-client/simple_vm_client/test_virtualmachinehandler.py", line 168, in test_rescue_server self.handler.openstack_connector.rescue_server.assert_called_once_with( File "/usr/lib/python3.10/unittest/mock.py", line 941, in assert_called_once_with return self.assert_called_with(*args, **kwargs) File "/usr/lib/python3.10/unittest/mock.py", line 929, in assert_called_with raise AssertionError(_error_message()) from cause AssertionError: expected call not found. Expected: rescue_server(openstack_id='vm_id') Actual: rescue_server(openstack_id='vm_id', admin_pass=None, image_ref=None)

Ran 306 tests in 3.103s

FAILED (failures=1)

The test is now updated and functioning