Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/os sdk 2 #437

Merged
merged 10 commits into from
Jan 5, 2024
Merged

Feat/os sdk 2 #437

merged 10 commits into from
Jan 5, 2024

Conversation

vktrrdk
Copy link
Member

@vktrrdk vktrrdk commented Dec 19, 2023

@dweinholz same as for old client with https://github.com/deNBI/simplevm-draft-repo/pull/463

Try to fulfill the following points before the Pull Request is merged:

  • The PR is reviewed by one of the team members.
  • If a linting PR exists, it must be merged before this PR is allowed to be merged.
  • If the PR is merged in the master then a release should be be made.
  • If the new code is readable, if not it should be well commented

For releases only:

  • If the review of this PR is approved and the PR is followed by a release then the .env file
    in the cloud-portal repo should also be updated.
  • If you are making a release then please sum up the changes since the last release on the release page using the clog tool with clog -F

@vktrrdk vktrrdk requested a review from dweinholz December 19, 2023 12:34
@vktrrdk vktrrdk changed the base branch from master to dev December 19, 2023 12:46
@vktrrdk vktrrdk merged commit 5e3cc70 into dev Jan 5, 2024
@dweinholz dweinholz deleted the feat/os_sdk_2 branch October 10, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant