Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ports #414

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Feat/ports #414

merged 2 commits into from
Nov 2, 2023

Conversation

dweinholz
Copy link
Contributor

@dweinholz dweinholz commented Nov 2, 2023

together:
#414
https://github.com/deNBI/simplevm-draft-repo/pull/425
https://github.com/deNBI/simplevm-webapp-draft/pull/775

Try to fulfill the following points before the Pull Request is merged:

  • The PR is reviewed by one of the team members.
  • If a linting PR exists, it must be merged before this PR is allowed to be merged.
  • If the PR is merged in the master then a release should be be made.
  • If the new code is readable, if not it should be well commented

For releases only:

  • If the review of this PR is approved and the PR is followed by a release then the .env file
    in the cloud-portal repo should also be updated.
  • If you are making a release then please sum up the changes since the last release on the release page using the clog tool with clog -F

@dweinholz dweinholz requested a review from vktrrdk November 2, 2023 14:53
@dweinholz dweinholz changed the base branch from master to dev November 2, 2023 14:53
simple_vm_client/ttypes.py Dismissed Show dismissed Hide dismissed
@vktrrdk vktrrdk merged commit fde8a67 into dev Nov 2, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants