Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #6098

Merged
merged 23 commits into from
Jun 17, 2024
Merged

Dev #6098

merged 23 commits into from
Jun 17, 2024

Conversation

dweinholz
Copy link
Contributor

Try to fulfill the following points before the Pull Request is merged:

  • Give a meaningfull description for the PR
  • The PR is reviewed by one of the team members.
  • If a linting PR exists, it must be merged before this PR is allowed to be merged.
  • It must be checked if anything in the Readme must be adjusted (development-, production-, setup).
  • It must be checked if any section in the wiki (https://cloud.denbi.de/wiki/) should be adjusted.
  • If the PR is merged in the master then a release should be be made.
  • The PR is responsive on smaller screens.
  • If the requirements.txt have changed, check if the patches still work
  • If the new code is readable, if not it should be well commented
  • In case the code is not well commented: An respectice commenting issue with tag "important" is opened.
  • If a squash of commits is required, it has been performed or will be performed at final merge
  • Finally a second team member checks if all requirements met

For releases only:

  • If the review of this PR is approved and the PR is followed by a release then the .env file
    in the cloud-portal repo should also be updated.

dweinholz and others added 23 commits May 3, 2024 11:51
@dweinholz
started refagoring
c97b3f1
@dweinholz
more refactoring
4a2e800
@dweinholz
unset pi refactored
dbf740a
@dweinholz
application adjustment works
e7b6490
@dweinholz
adjusting lifetime and application works
c602654
@dweinholz
all tabs working
cf9d996
@dweinholz
own component for facility and vo actions
31865d2
@dweinholz
refactord facility submitted
00b3a8b
@dweinholz
facility methods refactored
d649673
@dweinholz
feat(Application):refactored application vo and facility view, also m…
204b3f5 
…odification and resources to one tab and show pi numbers of projects
@dweinholz
removed old code
d76e81c
@dweinholz @github-actions
fix(Linting):blacked code
dcc2637
@dweinholz
Merge pull request #6084 from deNBI/fix(linting)_refacotr-pi_countt_a…
58fc228 
…nd_faster_application_loading

Automated TsLint Linting [refs/heads/refacotr/pi_countt_and_faster_application_loading]
@vktrrdk
fix for kubernetes flag
e781b9b
@dweinholz
fixed loading pi
e198276
@denbicloud
Branch was auto-updated.
fd206b6
@denbicloud
Branch was auto-updated.
c2965d1
@denbicloud
Branch was auto-updated.
edea48e
@denbicloud
Branch was auto-updated.
e1cfefe
@renovate
feat(Dependencies): Update all non-major dependencies
e0c8b33 
| datasource | package             | from     | to       |
| ---------- | ------------------- | -------- | -------- |
| npm        | @types/node         | 20.12.12 | 20.12.14 |
| npm        | eslint-plugin-jsdoc | 48.2.5   | 48.2.7   |
| npm        | lint-staged         | 15.2.4   | 15.2.5   |
| docker     | nginx               | 1.26.0   | 1.26.1   |
| npm        | vite                | 5.2.11   | 5.2.12   |
@denbicloud
Branch was auto-updated.
db7dbe8
@dweinholz
linting fix
82a299e
@dweinholz
Merge pull request #6085 from deNBI/refacotr/pi_countt_and_faster_app…
f7271dd 
…lication_loading

Refacotr/pi countt and faster application loading
@dweinholz dweinholz merged commit 425d09f into staging Jun 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweinholz @vktrrdk @denbicloud