Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjusted visibility #5919

Merged
merged 1 commit into from
Oct 18, 2023
Merged

adjusted visibility #5919

merged 1 commit into from
Oct 18, 2023

Conversation

vktrrdk
Copy link
Member

@vktrrdk vktrrdk commented Oct 18, 2023

@dweinholz again

Try to fulfill the following points before the Pull Request is merged:

  • Give a meaningfull description for the PR
  • The PR is reviewed by one of the team members.
  • If a linting PR exists, it must be merged before this PR is allowed to be merged.
  • It must be checked if anything in the Readme must be adjusted (development-, production-, setup).
  • It must be checked if any section in the wiki (https://cloud.denbi.de/wiki/) should be adjusted.
  • If the PR is merged in the master then a release should be be made.
  • The PR is responsive on smaller screens.
  • If the requirements.txt have changed, check if the patches still work
  • If the new code is readable, if not it should be well commented
  • In case the code is not well commented: An respectice commenting issue with tag "important" is opened.
  • If a squash of commits is required, it has been performed or will be performed at final merge
  • Finally a second team member checks if all requirements met

For releases only:

  • If the review of this PR is approved and the PR is followed by a release then the .env file
    in the cloud-portal repo should also be updated.

@vktrrdk vktrrdk requested a review from dweinholz October 18, 2023 09:51
@dweinholz dweinholz merged commit ef8bfde into master Oct 18, 2023
5 of 7 checks passed
@dweinholz dweinholz deleted the fix/svmlink branch October 18, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweinholz dweinholz dweinholz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vktrrdk @dweinholz