Fixed error related to Router only returning the FIRST of many potential matches rather than the correct one. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l match rather than just returning the first match, thereby ensuring matches that are merely a subset of the provided path are not erroneously returned as they were previously. Also added and wired up a new Route and corresponding View (PostViewCategories) to test the new routing logic.
tjmarkowitz
approved these changes
Jun 21, 2021
|
Thanks for this suggestion. Sorry it took me over a year to reply to this PR. I like it but can you please remove the PostViewCategories view because it's not part of the video. |
felix-d1strict
suggested changes
Jul 17, 2022
| }; | ||
| }); | ||
|
|
||
| let match = potentialMatches.find(potentialMatch => potentialMatch.result !== null); | ||
|
|
There was a problem hiding this comment.
A (unnecessary) empty line. 😉
|
|
||
| }) | ||
|
|
||
|
|
There was a problem hiding this comment.
There is also an unnecessarily empty lines here.
Comment on lines
+43
to
+51
| var match | ||
| potentialMatches.forEach(entry =>{ | ||
|
|
||
| if(entry.result != null) { | ||
|
|
||
| match = (match === undefined || entry.route.path.length > match.route.path.length) ? entry : match | ||
| } | ||
|
|
||
| }) |
There was a problem hiding this comment.
This one should be looked at again more closely.
In addition to an = at the beginning, a semicolon is also missing at the end too.
There are also unnecessary empty lines here, again that can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified routing logic to match against the longest possible potential match rather than just returning the first match, thereby ensuring matches that are merely a subset of the provided path are not erroneously returned as they were previously. Also added and wired up a new Route and corresponding View (PostViewCategories) to test the new routing logic.