Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a check for criteria's symbols in list search - Sequelize 4 #223

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

GabeAtWork
Copy link

@GabeAtWork GabeAtWork commented Oct 17, 2017

Fixes the search and uses Sequelize's Symbols (as per @michailpanagiotis's work).

This results in a dependency bump to Sequelize 4

@GabeAtWork
Copy link
Author

Fixes #220

Copy link

@micksatana micksatana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Working.

@GabeAtWork
Copy link
Author

GabeAtWork commented Oct 20, 2017

This PR will now have a dependency bump for Sequelize 4

I reopened the previous PR without the dependency bump : #224

@GabeAtWork GabeAtWork changed the title Adds a check for criteria's symbols in list search Adds a check for criteria's symbols in list search - Sequelize 4 Oct 20, 2017
@GabeAtWork
Copy link
Author

Tests are failing even with the dependency bump. @michailpanagiotis it'll take more work to make epilogue compatible with Sequelize 4

@tomasgvivo tomasgvivo mentioned this pull request Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants