Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update game events #71

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Update game events #71

merged 3 commits into from
Sep 26, 2023

Conversation

LarchLiu
Copy link
Contributor

Update game events:

  1. add cards event
  2. extract description of card and substitution. such as 8. Yellow card , Foul for card or Injury for subsitiution.
  3. add assisted player(if make this change should also add player_assist_id for transfermarkt_datasets in base_game_events.sql and game_events.sql)

https://www.transfermarkt.co.uk/austin-fc_los-angeles-galaxy/index/spielbericht/3996407

dcaribou
dcaribou approved these changes Sep 26, 2023
View reviewed changes
Copy link
Owner

@dcaribou dcaribou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great.

Many thanks again for your contribution @LarchLiu 😄

@dcaribou dcaribou merged commit fad50d5 into dcaribou:main Sep 26, 2023
1 check passed
@LarchLiu LarchLiu mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcaribou dcaribou dcaribou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LarchLiu @dcaribou