Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Assertion when no event minute data is available #70

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Fix: Assertion when no event minute data is available #70

merged 2 commits into from
Sep 26, 2023

Conversation

LarchLiu
Copy link
Contributor

The background_position_in_px_to_minute will trigger an AssertionError if there is no minute data available for the GOAL or SUBSTITUTION events.

https://www.transfermarkt.co.uk/spielbericht/index/spielbericht/2283290

<span class="sb-sprite-uhr-klein" style="background-position: -0px -433px;">
    &nbsp;
</span>

dcaribou
dcaribou approved these changes Sep 25, 2023
View reviewed changes
Copy link
Owner

@dcaribou dcaribou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @LarchLiu 😄

@dcaribou dcaribou merged commit b138644 into dcaribou:main Sep 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcaribou dcaribou dcaribou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LarchLiu @dcaribou