Fix issue with dynamic array fields in PHP 8.2 #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would issue "Indirect modification of overloaded property has no effect" in Unmarshaller.php:353 and not set the value otherwise.
The problem is that
will first call
AbstractModel::__get($field)
and thenAbstractModel::__set($field)
with[$k]
modified and notAbstractModel::__set($field[$k])
immediately.Because
__get(()
didn't return a reference, the__set()
didn't have an actual effect.I went with return the value from
__get()
via reference, because it needed only a few lines of changes.Another option would have been to build up the array (call it e.g.
$unmarshalledArray
) for$field
inunmarshalArray()
and issue one$this->{$field} = $unmarshalledArray;
. This would bypass__get()
and immediately call__set()
, avoiding the issue as well.