refactor: Move WebSocket implementation to shinkai-http-api #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Create IdentityManagerTrait in identity module - Move WebSocketManager to websocket module - Update dependencies and imports Co-Authored-By: Nicolas Arqueros <[email protected]>
- Add ws_routes.rs to websocket module - Update imports to use crate-relative paths - Expose WebSocket routes in mod.rs Co-Authored-By: Nicolas Arqueros <[email protected]>
- Update WebSocketManager import to use shinkai-http-api - Update ws_manager initialization with new constructor - Simplify ws_manager_trait casting Co-Authored-By: Nicolas Arqueros <[email protected]>
- Move ws_manager.rs and ws_routes.rs to shinkai-http-api - Extract IdentityManagerTrait interface - Update Node to use new implementation - Add WebSocket routes to HTTP server Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Co-Authored-By: Nicolas Arqueros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move WebSocket implementation from shinkai-node to shinkai-http-api library and integrate with HTTP server.
Changes:
Testing:
Link to Devin run: https://app.devin.ai/sessions/382b85e0eb78468187181329d551a3c8