Remove step history and execution context #717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicarq
reviewed
Dec 12, 2024
| if let Some(step_history) = job_step_history { | ||
| prompt.add_step_history(step_history, 97); | ||
| } | ||
|
|
||
| // Add tools if any. Decrease priority every 2 tools |
There was a problem hiding this comment.
@benolt we removed the step history here but we are not adding the previous messages to the conversation 👀
nicarq
reviewed
Dec 12, 2024
| @@ -494,345 +427,6 @@ mod tests { | |||
| assert_eq!(job_message_4.content, "Hello World 4".to_string()); | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
There was a problem hiding this comment.
@benolt these test include step history but they are also testing the tree structure of the messages, we shouldnt remove the entire test
benolt
force-pushed
the
bence/drop-step-history
branch
from
9fb0bfc to
bc962bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.