Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint / burn #172

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Mint / burn #172

merged 4 commits into from
Mar 4, 2024

Conversation

gostkin
Copy link
Contributor

@gostkin gostkin commented Jan 10, 2024

Provides endpoints to fetch mint / burn events from carp

@gostkin gostkin force-pushed the egostkin/mint-burn-queries branch from 3a9e9d0 to 616974f Compare January 16, 2024 14:39
@gostkin gostkin marked this pull request as ready for review January 16, 2024 14:40
Comment on lines 16 to 20
@Route('asset/mint-burn-history')
export class MintRangeController extends Controller {
@SuccessResponse(`${StatusCodes.OK}`)
@Post()
public async projectedNftRange(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing documentation for the endpoints (see the other controllers for how to generate docs from comments)

@SebastienGllmt
Copy link
Contributor

@ecioppettini to see what I mean, look at the OpenAPI docs. Endpoints such as the one in this PR, AssetUtxos, DelegationForAddress, DelegationForPool and ProjectedNftRange are all missing documentation (it becomes just an endpoint with no description of what it does)

https://dcspark.github.io/carp/openapi#operation/AddressUsed

@SebastienGllmt SebastienGllmt merged commit 577b658 into main Mar 4, 2024
2 checks passed
@SebastienGllmt SebastienGllmt deleted the egostkin/mint-burn-queries branch March 4, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants