Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions - Ubuntu, Windows, and macOS #1754

Merged
merged 7 commits into from
Aug 30, 2020
Merged

Conversation

kum-deepak
Copy link
Collaborator

The initial version, currently it runs our current test workflow on the latest Ubuntu, Windows, and macOS.

These should be possible to be extended to include OS/browser combinations that we intend to test.

@kum-deepak
Copy link
Collaborator Author

Current config:

  • Chrome, Firefox on Ubuntu
  • Edge, Chrome, Firefox on Windows
  • Safari, Chrome, Firefox on MacOS

Latest OS, Node 12

@kum-deepak
Copy link
Collaborator Author

I have removed Saucelabs related settings.

@kum-deepak
Copy link
Collaborator Author

Safari Headless is not supported with the NPM version of the plugin, so used from karma-runner/karma-safari-launcher#22

@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Aug 30, 2020

Wow, this is great!

It's funny that it runs all the tests twice, once for push and once for pull_request, but I guess that is normal.

Edit: I see, that's because you had to create the branch on the main repo in order to test actions, so it's testing push to the main repo as well as the PR.

@gordonwoodhull gordonwoodhull merged commit 5b24095 into develop Aug 30, 2020
@gordonwoodhull
Copy link
Contributor

This is much faster too!

What a relief to be done with unreliable saucelabs. It was great the first few years but it really deteriorated recently.

@kum-deepak
Copy link
Collaborator Author

We can actually drop one of Ubuntu or Travis as both are testing the same stuff.

@gordonwoodhull
Copy link
Contributor

Let's drop Travis in a month or two, when we're sure everything is working properly.

It's nice to have the redundancy (especially since it runs in parallel).

@kum-deepak kum-deepak deleted the github-actions branch August 30, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants