Do 5 retries for resource list updates

Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis · Oct 2, 2024 · 931fa37 · 931fa37
1 parent c26fb39
commit 931fa37
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java b/src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java
@@ -691,7 +691,7 @@ public void addResourceToStateIndex(
                 getAndUpdateResourceInStateDocumentWithRetries(
                     workflowId,
                     newResource,
-                    3,
+                    5,
                     ActionListener.runBefore(listener, context::restore)
                 );
             }

diff --git a/src/test/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandlerTests.java b/src/test/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandlerTests.java
@@ -700,7 +700,7 @@ public void testAddResourceToStateIndexWithRetries() throws IOException {
         verify(retryListener, times(1)).onResponse(responseCaptor.capture());
         assertEquals("this_id", responseCaptor.getValue().getContent().get(WorkflowResources.CONNECTOR_ID));
 
-        // test failure on 4th after 3 retries even if 5th would have been success
+        // test failure on 6th after 5 retries even if 7th would have been success
         @SuppressWarnings("unchecked")
         ActionListener<WorkflowData> threeRetryListener = mock(ActionListener.class);
         doAnswer(invocation -> {
@@ -719,6 +719,14 @@ public void testAddResourceToStateIndexWithRetries() throws IOException {
             ActionListener<UpdateResponse> responseListener = invocation.getArgument(1);
             responseListener.onFailure(conflictException);
             return null;
+        }).doAnswer(invocation -> {
+            ActionListener<UpdateResponse> responseListener = invocation.getArgument(1);
+            responseListener.onFailure(conflictException);
+            return null;
+        }).doAnswer(invocation -> {
+            ActionListener<UpdateResponse> responseListener = invocation.getArgument(1);
+            responseListener.onFailure(conflictException);
+            return null;
         }).doAnswer(invocation -> {
             // we'll never get here
             ActionListener<UpdateResponse> responseListener = invocation.getArgument(1);