This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Progress bar: Only show one line's worth #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
General updates
Update phantomjs-prebuilt to 2.1.5 Also remove peer dependence since that has been removed in grunt 1.0.0 causing grunt 1.0.0 to fail. We doint need to support nodejs 0.8 either.
build: Update phantomjs-prebuilt to 2.1.5 and drop peer dependencies
dependencies: Update phantomjs-prebuilt from 2.1.5 to 2.1.6
Using the Wikimedia fork of the version only changes the hosting, but allows us to bypass the rate limiting from the official host that is causing us so many issues in CI production.
dependencies: Update phantomjs-prebuilt to 2.1.6-wmf
dependencies: Tweak phantomjs-prebuilt fork version
dependencies: Use phantomjs.git#v2.1.6-wmf rather than a git hash
They changed there download location to use the binary from GitHub hosted on there release page. Which means we doint need to customise it now.
Update phantomjs-prebuilt to 2.1.7 (stop using fork)
Update phantomjs-prebuilt to 2.1.14
Update pngjs to 3.0.1
The #open method expects an URL, not a path. This used to work, but it seems recent PhantomJS releases are stricter (at least on Windows).
phantomjs-prebuilt 2.1.14 → 2.1.16 grunt 0.4.5 → 1.0.3 grunt-contrib-jshint 1.0.0 → 2.0.0 grunt-contrib-nodeunit 0.4.1 → 2.0.0 grunt-contrib-clean 1.0.0 → 2.0.0 pngjs 3.0.1 → 3.4.0
build: Bump dependency and devDependencies to latest
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm picking 25 less than
process.stdout.columnswhich is possibly a bit pessimistic for some users, but works well enough for my repo (with > 700 SVGs to convert). Possibly if it was going to take > 99s it'd be a pain. :-)Fixes #28