Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Grunt 'rename' fix #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

samdbeckham
Copy link

There was an issue that cropped up when you used Grunt's rename function in the grunt config. Instead of saving the file to the desired location, it would create a folder at that location and save the icon within it, preceded by the CWD folder structure.

Reading that back, it makes very little sense (apologies, I'm a little hungover today), try it it out though and you'll see what I mean.

I've popped in some tests, updated the config and squashed the bug though.

@samdbeckham
Copy link
Author

This might make the issue a little clearer.

Config:

Result:

@samdbeckham
Copy link
Author

Any thoughts on this @dbushell ?

@theme
Copy link

theme commented Jun 2, 2015

I stumbled on the same stone. Seems #9 introduced this.
Maybe the default behavior is better not mutate file's src and dest attribute.
Maybe an option 'preserve-path' for #9 's needs. Thanks @dbushell.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants