zv: Multiple lists support for derive macros. #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbocool3r
force-pushed
the
multiple-lists
branch
2 times, most recently
from
a728b63
to
08bf644
Compare
|
Looks like it's ready for review |
|
Cool. Still no emojis? 😿 Could you please add those, it helps me as a very visual person to follow the history better and especially in writing release notes from the commit log. Emoji-less commits also look out of place in our git history now a days. :) |
|
Oh and |
zeenix
reviewed
Sep 14, 2024
There was a problem hiding this comment.
Awesome. Functionality wise, it looks great. Only nits about commit log of last commit. 😆
- Could just be "zd: Allow
zbusattribute in macros". This will fit in the 50 chars limit and is sufficient. - It would be good to mention that this will make it possible to resolve zb: Re-export zvariant types & macros directly #807.
Indeed. Functionality wise, this is ready for merge. :) |
turbocool3r
force-pushed
the
multiple-lists
branch
from
08bf644
to
c125ce2
Compare
|
Just reworded everything, added emojis. Not sure if these are the best choice... I was only familiar with 🍻 gitmoji before 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple attribute list identifiers to
def_attrs!macro fromzvariant_utilsand uses this inzvariant_deriveto avoid mentioningzvariantwhen using macros out ofzbus(as described in #820).