Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Suggestions for Snowflake Iceberg Configurations Doc #6365

Draft
wants to merge 2 commits into
base: current
Choose a base branch
from
Draft

Add Suggestions for Snowflake Iceberg Configurations Doc #6365

wants to merge 2 commits into from

Conversation

LProcopi15
Copy link

@LProcopi15 LProcopi15 commented Oct 25, 2024 •
edited
Loading

What are you changing in this pull request and why?

Add Suggestions for Snowflake Iceberg Configurations Doc: https://docs.getdbt.com/reference/resource-configs/snowflake-configs#iceberg-table-format

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@welcome Welcome
Copy link

welcome bot commented Oct 25, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@vercel Vercel
Copy link

vercel bot commented Oct 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 20, 2024 5:34pm

@runleonarun runleonarun added the new contributor Label for first-time contributors label Oct 25, 2024
@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address and removed new contributor Label for first-time contributors labels Oct 25, 2024
LProcopi15
LProcopi15 commented Oct 25, 2024
View reviewed changes
website/docs/reference/resource-configs/snowflake-configs.md

For now, to create Iceberg tables, you must implement a [behavior flag](/reference/global-configs/behavior-changes) due to performance impact related to using Iceberg tables. Snowflake does not support `is_iceberg` on the `Show Objects` query, which dbt depends on for metadata.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the part about SHOW OBJECTS as it felt a little niche / tangental, but let me know if you disagree!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw this pop up - I disagree with this :) This is a dbt metadata performance impact rather than from using Iceberg tables. (also this helps snowflake customers advocate for us)

@matthewshaver
Copy link
Contributor

Hi @LProcopi15, Thank you so much for this submission. I'm ready to move this forward for you once you address @amychen1776's feedback in the document. It looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amychen1776 amychen1776 amychen1776 left review comments

@dataders dataders Awaiting requested review from dataders dataders will be requested when the pull request is marked ready for review dataders is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LProcopi15 @matthewshaver @amychen1776 @runleonarun