Fixing set up ci forwarder #4453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Docs team
matthewshaver
approved these changes
Nov 13, 2023
|
Hi @runleonarun The link redirect looks good. Don't think it's a problem linking to the top level of the guide although this feels like something that should have a corresponding page in the /docs directory that could be even more appropriate. Maybe an issue for improvement? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Fixing link so old search goes to an actual page for https://docs.getdbt.com/guides/orchestration/set-up-ci/lint-on-push.
It was forwarding to
https://docs.getdbt.com/%20/guides/set-up-cibut now forwards correctly tohttps://docs.getdbt.com/guides/set-up-ci❓ One question for reviewers: Is this forwarded link helpful? I wavered between directly linking to Step 4 for SQL Fluff and linking to the entire guide. I opted for the guide because it feels less fragile.