Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-hook-post-hook.md #4393

Merged
merged 20 commits into from
Nov 8, 2023
Merged

Update pre-hook-post-hook.md #4393

merged 20 commits into from
Nov 8, 2023

Conversation

mirnawong1
Copy link
Contributor

clarify transactions not supported per slack thread

@mirnawong1
Update pre-hook-post-hook.md
cb232ee 
clarify transactions not supported
@mirnawong1 mirnawong1 requested a review from a team as a code owner November 3, 2023 12:11
@vercel Vercel
Copy link

vercel bot commented Nov 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 9:28pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Nov 3, 2023
@mirnawong1
Copy link
Contributor Author

Waiting on team for feedback and will follow up this week

patkearns10
patkearns10 requested changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@patkearns10 patkearns10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I would suggest making this less open to interpretation as well.

website/docs/reference/resource-configs/pre-hook-post-hook.md Outdated Show resolved Hide resolved
@mirnawong1
Copy link
Contributor Author

hey @patkearns10 , thanks so much for that and folded in your feedback - can you give it a look and approve? thank you again!

@patkearns10 patkearns10 self-requested a review November 8, 2023 21:29
patkearns10
patkearns10 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@patkearns10 patkearns10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌵 LGTM!

@mirnawong1 mirnawong1 merged commit 050ae3e into current Nov 8, 2023
2 checks passed
@mirnawong1 mirnawong1 deleted the mirnawong1-patch-12 branch November 8, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patkearns10 patkearns10 patkearns10 approved these changes

Assignees
No one assigned
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirnawong1 @patkearns10