Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving the guide content to the new format #4361

Merged
merged 67 commits into from
Nov 11, 2023
Merged

Moving the guide content to the new format #4361

merged 67 commits into from
Nov 11, 2023

Conversation

runleonarun
Copy link
Collaborator

@runleonarun runleonarun commented Oct 28, 2023 •
edited
Loading

What are you changing in this pull request and why?

Moving content to new guide area and best practices section.

This is part of the quickstart v2 project described in these docs:

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@runleonarun runleonarun requested a review from a team as a code owner October 28, 2023 00:37
@vercel
Copy link

vercel bot commented Oct 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2023 0:28am

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: large This change will more than a week to address and might require more than one person Docs team Authored by the Docs team @dbt Labs labels Oct 28, 2023
@nghi-ly
Update website/docs/guides/custom-cicd-pipelines.md
d866035 
per style guide, use sentence case for titles
nghi-ly
nghi-ly approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@nghi-ly nghi-ly merged commit 01c79bc into quickstarts-q32023-update Nov 11, 2023
5 checks passed
@nghi-ly nghi-ly deleted the quickstart-content-updates branch November 11, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghi-ly nghi-ly nghi-ly approved these changes

@matthewshaver matthewshaver matthewshaver approved these changes

@dataders dataders Awaiting requested review from dataders

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: large This change will more than a week to address and might require more than one person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@runleonarun @matthewshaver @nghi-ly