Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta config for semantic models #4218

Merged
merged 9 commits into from
Nov 8, 2023
Merged

meta config for semantic models #4218

merged 9 commits into from
Nov 8, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Oct 7, 2023 •
edited
Loading

related to: #4180
related to: #4281

What are you changing in this pull request and why?

  • Mention config in dbt_project.yml (like for models, seeds, and snapshots)
  • Match the style for other resource types for models/semantic_models.yml
  • Clarify that meta is no longer "always" available as a top-level key (see #8766)

Other

  • Here's an open issue to add meta config for metrics: #3957
  • Opened an issue to add version blocks for any other resource types for which it is applicable: #4224
  • Opened an issue to add code examples to meta for dbt_project.yml (like enabled has them): #4415

🎩

Previews

v1.7

image

Checklist

  • I have tested that the code examples work
  • I have tested that the changes look correct in the Vercel preview
  • Review the Content style guide and About versioning so my content adheres to these guidelines.

@vercel
Copy link

vercel bot commented Oct 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 9:21pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Oct 7, 2023
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Oct 7, 2023
@dbeatty10 dbeatty10 changed the title Add docs for configs for semantic models meta config for semantic models Oct 7, 2023
@dbeatty10 dbeatty10 mentioned this pull request Oct 7, 2023
Merged
5 tasks
@matthewshaver
Copy link
Contributor

Closing as duplicate. Addressed in : #4231

@dbeatty10 dbeatty10 reopened this Nov 8, 2023
@github-actions github-actions bot added size: x-small This change will take under 3 hours to fix. and removed size: small This change will take 1 to 2 days to address labels Nov 8, 2023
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Nov 8, 2023
@dbeatty10 dbeatty10 mentioned this pull request Nov 8, 2023
Open
1 task
@dbeatty10 dbeatty10 marked this pull request as ready for review November 8, 2023 03:00
@dbeatty10 dbeatty10 requested a review from a team as a code owner November 8, 2023 03:00
@dbeatty10 dbeatty10 mentioned this pull request Nov 8, 2023
Closed
1 task
@matthewshaver matthewshaver merged commit cfca7c4 into current Nov 8, 2023
5 checks passed
@matthewshaver matthewshaver deleted the dbeatty/semantic-models-meta-config branch November 8, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbeatty10 @matthewshaver