Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Oracle and Materialize to trusted adapters lisst #4170

Merged
merged 7 commits into from
Oct 6, 2023
Merged

Add Oracle and Materialize to trusted adapters lisst #4170

merged 7 commits into from
Oct 6, 2023

Conversation

dataders
Copy link
Contributor

@dataders dataders commented Oct 2, 2023 •
edited
Loading

What are you changing in this pull request and why?

resolves: #4034
resolves: #4090

These adapters are now trusted. updating docs site accordingly.

image

@dataders dataders requested a review from a team as a code owner October 2, 2023 15:23
@vercel
Copy link

vercel bot commented Oct 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 6:54pm

@github-actions github-actions bot added content Improvements or additions to content size: large This change will more than a week to address and might require more than one person labels Oct 2, 2023
@dataders
Copy link
Contributor Author

dataders commented Oct 2, 2023

@morsapaes @dehume @aosingh seeking confirmation that I'm using the correct .svg

@dehume
Copy link

dehume commented Oct 2, 2023

That looks correct. From our logo collection materialize-purple-mark.svg
materialize-purple-mark

mirnawong1
mirnawong1 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @dataders (both in dark and light mode)!!

Screenshot 2023-10-03 at 09 34 52

@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: large This change will more than a week to address and might require more than one person labels Oct 5, 2023
@dataders
Copy link
Contributor Author

dataders commented Oct 5, 2023

@aosingh looking at the new preview, it seems the logo:

  1. is not visible for light mode and
  2. got smaller (as compared to the other .svg logos)
image image

@aosingh
Copy link
Contributor

aosingh commented Oct 6, 2023

@dataders this looks good. Thank you

@dataders dataders enabled auto-merge October 6, 2023 18:48
@dataders dataders merged commit 240bce9 into current Oct 6, 2023
7 checks passed
@dataders dataders deleted the more_trusted_adapters branch October 6, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

list dbt-oracle as trusted adapter Trust dbt-materialize
4 participants
@dataders @dehume @aosingh @mirnawong1