-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove-1.6 from future releases table #4047
Conversation
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
happy to get this merged but i'm wondering if we can just combine both tables. I'm going to try to mock something up and share here @dbeatty10 |
hey @dbeatty10 , here's how i think it could look like. there's still some manual updates but at least it's updating once. what do you think of the proposed table? |
Like your thinking about mitigating this issue happening again in the future 😎 OptionsGoing the table route, we have 2 main options:
Either way, I'm attracted to listing the releases from most recent to least. That way, the freshest (and most relevant) things are at the top and the oldest (least relevant) things are at the bottom. My opinionFrom the perspective of a human trying to visually read the information, I'm also most attracted to three separate tables. From the perspective of trying to ingest this data into a database table (or trying to keep thing in sync when updating 😉), then I'd prefer one unified table. So my preference is something like this: Planned future releasesFuture release dates are tentative and subject to change.
Supported Versions
Unsupported Versions
*All versions of dbt Core since v1.0 are available in dbt Cloud until further notice. Versions that are EOL do not receive any fixes. For the best support, we recommend upgrading to a version released within the past 12 months. SummaryI don't have strong feeling on the table placement, row ordering, or table format of the "planned future releases". But my eye and brain does prefer it to be visually separated from the "supported" and "unsupported" releases. The emojis were a little intense for me (and they shouldn't be necessary with separate tables), so I dropped them above so we can see how it looks and feels. |
hey @dbeatty10 i've learned from you 🙏 i did see python's table and i love it too! but the reason i sugg the unified table approach is because in the future, we'd have to update all 3 tables when a version changes. another reason is - what makes an 'unsupported version' unsupported? 1.0-1.2 are still available in dbt cloud and i think it's confusing to say they're 'unsupported' when they're still available in cloud. see slack thread for context on orgs upgrading. i wish that this could be done/shifted automatically! I think you're right about the order, best to be descending. i'll go ahead and merge this pr for you to not hold it up but i'll open up an issue as it's worth a good discussion. |
Preview: About dbt Core versions: Planned future releases
What are you changing in this pull request and why?
v1.6 is listed here as part of the "Planned future releases", so we should remove it now that it has been released.
Checklist