Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove-1.6 from future releases table #4047

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Sep 8, 2023

Preview: About dbt Core versions: Planned future releases

What are you changing in this pull request and why?

v1.6 is listed here as part of the "Planned future releases", so we should remove it now that it has been released.

Checklist

@dbeatty10 dbeatty10 requested a review from a team as a code owner September 8, 2023 00:06
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Sep 8, 2023
@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 51fecd4
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64fb308142e1e10008b2df81
😎 Deploy Preview https://deploy-preview-4047--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mirnawong1
Copy link
Contributor

mirnawong1 commented Sep 8, 2023

happy to get this merged but i'm wondering if we can just combine both tables. I'm going to try to mock something up and share here @dbeatty10

@mirnawong1
Copy link
Contributor

mirnawong1 commented Sep 8, 2023

hey @dbeatty10 , here's how i think it could look like. there's still some manual updates but at least it's updating once.
one thing i was trying to do was see if i can add a dynamic badge that displays the release date but i can't seem to do it other than it being static. but it would be cool to have a badge that can automatically reflect the release date (and maybe even release status) Microsoft does this similarly

what do you think of the proposed table?

Screenshot 2023-09-08 at 13 01 21

@dbeatty10
Copy link
Contributor Author

there's still some manual updates but at least it's updating once.

Like your thinking about mitigating this issue happening again in the future 😎

Options

Going the table route, we have 2 main options:

  1. One unified table (like Microsoft Edge)
  2. Separate tables for Supported, Unsupported, and Upcoming releases (like Python)

Either way, I'm attracted to listing the releases from most recent to least. That way, the freshest (and most relevant) things are at the top and the oldest (least relevant) things are at the bottom.

My opinion

From the perspective of a human trying to visually read the information, I'm also most attracted to three separate tables.

From the perspective of trying to ingest this data into a database table (or trying to keep thing in sync when updating 😉), then I'd prefer one unified table.

So my preference is something like this:

Planned future releases

Future release dates are tentative and subject to change.

dbt Core Initial Release Support Level Critical Support Until
v1.9 Apr 2024 Apr 2025
v1.8 Jan 2024 Jan 2025
v1.7 Oct 2023 Oct 2024

Supported Versions

dbt Core Initial Release Support Level Critical Support Until
v1.6 Jul 31, 2023 Active Jul 30, 2024
v1.5 Apr 27, 2023 Critical Apr 27, 2024
v1.4 Jan 25, 2023 Critical Jan 25, 2024
v1.3 Oct 12, 2022 Critical Oct 12, 2023

Unsupported Versions

dbt Core Initial Release Support Level Critical Support Until
v1.2 Jul 26, 2022 End of Life* Jul 26, 2023
v1.1 Apr 28, 2022 End of Life* Apr 28, 2023
v1.0 Dec 3, 2021 End of Life* Dec 3, 2022
v0.X (Various dates) Deprecated Deprecated

*All versions of dbt Core since v1.0 are available in dbt Cloud until further notice. Versions that are EOL do not receive any fixes. For the best support, we recommend upgrading to a version released within the past 12 months.

Summary

I don't have strong feeling on the table placement, row ordering, or table format of the "planned future releases". But my eye and brain does prefer it to be visually separated from the "supported" and "unsupported" releases.

The emojis were a little intense for me (and they shouldn't be necessary with separate tables), so I dropped them above so we can see how it looks and feels.

@mirnawong1
Copy link
Contributor

mirnawong1 commented Sep 8, 2023

hey @dbeatty10 i've learned from you 🙏

i did see python's table and i love it too! but the reason i sugg the unified table approach is because in the future, we'd have to update all 3 tables when a version changes. another reason is - what makes an 'unsupported version' unsupported? 1.0-1.2 are still available in dbt cloud and i think it's confusing to say they're 'unsupported' when they're still available in cloud. see slack thread for context on orgs upgrading.

i wish that this could be done/shifted automatically! I think you're right about the order, best to be descending. i'll go ahead and merge this pr for you to not hold it up but i'll open up an issue as it's worth a good discussion.

@mirnawong1 mirnawong1 merged commit e8d73fe into current Sep 8, 2023
10 checks passed
@mirnawong1 mirnawong1 deleted the dbeatty/remove-1.6-from-future branch September 8, 2023 14:46
@mirnawong1 mirnawong1 mentioned this pull request Sep 12, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants