Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine trusted adapter issue template #4029

Merged
merged 1 commit into from
Sep 6, 2023
Merged

refine trusted adapter issue template #4029

merged 1 commit into from
Sep 6, 2023

Conversation

dataders
Copy link
Contributor

@dataders dataders commented Sep 6, 2023 •
edited
Loading

What are you changing in this pull request and why?

#4022, the first issue generated by this new template, presented some opportunities for refinement, predominantly:

  • markdown doesn't work in the template description, so I moved it to the markdown element
  • auto-assign me (@dataders)
  • make fields required
  • allow for submitters to provide the svg icon file (to save me time)

@dataders dataders requested a review from a team as a code owner September 6, 2023 18:45
@netlify
Copy link

netlify bot commented Sep 6, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com canceled.

Name Link
🔨 Latest commit eadc0cb
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64f8c8b9f886b0000881dcd7

@dataders dataders changed the title refine refine trusted adapter issue template Sep 6, 2023
@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Sep 6, 2023
jasnonaz
jasnonaz approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@jasnonaz jasnonaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@dataders dataders merged commit 75309a0 into current Sep 6, 2023
12 checks passed
@dataders dataders deleted the update-trusted-adapter-template branch September 6, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnonaz jasnonaz jasnonaz approved these changes

Assignees
No one assigned
Labels
size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dataders @jasnonaz