Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify unversioned models error and move to another page #4013

Merged
merged 8 commits into from
Sep 13, 2023
Merged

clarify unversioned models error and move to another page #4013

merged 8 commits into from
Sep 13, 2023

Conversation

mirnawong1
Copy link
Contributor

Moving the detecting breaking chagnes section from the contract page --> versions page.

Closes #4000

@mirnawong1 mirnawong1 requested a review from a team as a code owner September 5, 2023 10:57
@netlify
Copy link

netlify bot commented Sep 5, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit f7bd8db
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/6501cb8fa6e03100084dd253
😎 Deploy Preview https://deploy-preview-4013--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs and removed content Improvements or additions to content labels Sep 5, 2023
@mirnawong1
Copy link
Contributor Author

hey @MichelleArk or @graciegoheen , i've opened up this pr to address issue #4000. Can i ask you to give it a look to ensure it's technically accurate?

@github-actions github-actions bot added the content Improvements or additions to content label Sep 6, 2023
@mirnawong1 mirnawong1 merged commit 501bcb8 into current Sep 13, 2023
10 checks passed
@mirnawong1 mirnawong1 deleted the mwong-unversioned-models branch September 13, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver approved these changes

@MichelleArk MichelleArk MichelleArk approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model contracts: breaking change detection should raise an error for versioned models, otherwise a warning
3 participants
@mirnawong1 @MichelleArk @matthewshaver