Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Future scope] Distinguish 'inferred' vs 'partial' contracts #3998

Merged
merged 2 commits into from
Sep 11, 2023
Merged

[Future scope] Distinguish 'inferred' vs 'partial' contracts #3998

merged 2 commits into from
Sep 11, 2023

Conversation

jtcohen6
Copy link
Collaborator

What are you changing in this pull request and why?

Neither of these things exists yet — but they are distinct, and one is likely to exist much sooner than the other!

Context:

@jtcohen6 jtcohen6 requested a review from a team as a code owner August 31, 2023 12:16
@netlify
Copy link

netlify bot commented Aug 31, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit e01c10e
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64fefc8b588534000808665b
😎 Deploy Preview https://deploy-preview-3998--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Aug 31, 2023
mirnawong1
mirnawong1 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @jtcohen6 , am i good to merge this for you or do we need to wait for the core pr to merge?

@jtcohen6
Copy link
Collaborator Author

@mirnawong1 Thanks for the review - good to merge sooner!

@mirnawong1
Copy link
Contributor

thanks for the confirmation @jtcohen6. fixed the merged conflict and merging this for you now ✨

@mirnawong1 mirnawong1 merged commit 8d0d459 into current Sep 11, 2023
10 checks passed
@mirnawong1 mirnawong1 deleted the jerco/clarify-model-contract-inferred-partial branch September 11, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtcohen6 @mirnawong1