Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discovery-api: Remove legacy job schemas #3971

Merged
merged 4 commits into from
Aug 23, 2023
Merged

discovery-api: Remove legacy job schemas #3971

merged 4 commits into from
Aug 23, 2023

Conversation

eddowh
Copy link
Contributor

@eddowh eddowh commented Aug 22, 2023 •
edited
Loading

What are you changing in this pull request and why?

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@eddowh eddowh requested a review from a team as a code owner August 22, 2023 22:05
@eddowh eddowh self-assigned this Aug 22, 2023
@netlify
Copy link

netlify bot commented Aug 22, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 79fffa4
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64e6364a9567ae0008636c97
😎 Deploy Preview https://deploy-preview-3971--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content size: large This change will more than a week to address and might require more than one person labels Aug 22, 2023
@github-actions github-actions bot added the guides Knowledge best suited for Guides label Aug 23, 2023
mirnawong1
mirnawong1 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 lgtm, thanks @eddowh

@mirnawong1 mirnawong1 merged commit eab12de into current Aug 23, 2023
@mirnawong1 mirnawong1 deleted the meta-1539/remove-legacy-job-queries branch August 23, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees

@eddowh eddowh

Labels
content Improvements or additions to content guides Knowledge best suited for Guides size: large This change will more than a week to address and might require more than one person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddowh @mirnawong1