Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update meta config #3954

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Update meta config #3954

merged 4 commits into from
Aug 22, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Aug 19, 2023 •
edited
Loading

Preview

What are you changing in this pull request and why?

This PR is related to #3710. It handles the "update examples" part but doesn't handle the "add more explanation" part.

It fixes two things in particular:

  1. Aligns the example for sources with the recommended usage (that is most likely to behave correctly)
  2. Removes part of the example for macros that raises a Parsing Error

Checklist

@netlify
Copy link

netlify bot commented Aug 19, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 02659da
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64e499840a198f000884abc3
😎 Deploy Preview https://deploy-preview-3954--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Aug 19, 2023
@dbeatty10 dbeatty10 marked this pull request as ready for review August 19, 2023 02:12
@dbeatty10 dbeatty10 requested a review from a team as a code owner August 19, 2023 02:12
mirnawong1
mirnawong1 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 lgtm!

@mirnawong1 mirnawong1 merged commit 215b4b9 into current Aug 22, 2023
10 checks passed
@mirnawong1 mirnawong1 deleted the dbeatty/update-meta-config branch August 22, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbeatty10 @mirnawong1