Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sl-partner-integration-guide.md #3952

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Update sl-partner-integration-guide.md #3952

merged 8 commits into from
Aug 29, 2023

Conversation

rpourzand
Copy link
Contributor

  • added a note on where filters/string when we release it
  • added a note about graphql so we can add it once shipped

What are you changing in this pull request and why?

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@rpourzand
Update sl-partner-integration-guide.md
290e0da 
- added a note on where filters/string when we release it
- added a note about graphql so we can add it once shipped
@rpourzand rpourzand requested a review from a team as a code owner August 18, 2023 22:27
@netlify
Copy link

netlify bot commented Aug 18, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 29e4b0d
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64edb3489fdf420008988f02
😎 Deploy Preview https://deploy-preview-3952--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: small This change will take 1 to 2 days to address labels Aug 18, 2023
@vercel
Copy link

vercel bot commented Aug 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-getdbt-com ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2023 2:37pm

@mirnawong1
Copy link
Contributor

lgtm!

rpourzand
rpourzand commented Aug 28, 2023
View reviewed changes
Copy link
Contributor Author

@rpourzand rpourzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirnawong1 this one is ready to go if you approve. It has a few really small changes

mirnawong1
mirnawong1 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 @rpourzand !

@mirnawong1
Copy link
Contributor

merging this now @rpourzand

@mirnawong1 mirnawong1 merged commit ff17deb into current Aug 29, 2023
10 checks passed
@mirnawong1 mirnawong1 deleted the rpourzand-integration-guide-updates branch August 29, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content guides Knowledge best suited for Guides size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpourzand @mirnawong1