Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dbt-databricks docs #3946

Merged
merged 15 commits into from
Aug 18, 2023
Merged

update dbt-databricks docs #3946

merged 15 commits into from
Aug 18, 2023

Conversation

ericbaumann
Copy link
Contributor

@ericbaumann ericbaumann commented Aug 17, 2023

What are you changing in this pull request and why?

I am changing the layout of the dbt-databricks documentation to make it more clear what the available connection parameters are! These will be able to be utilized by folks using both core and cloud. For extended attributes, we link to these docs.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@ericbaumann ericbaumann requested a review from a team as a code owner August 17, 2023 21:29
@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 40a1407
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64dfab3d2a483100081f3086
😎 Deploy Preview https://deploy-preview-3946--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Aug 17, 2023
@@ -56,9 +54,51 @@ pip is the easiest way to install the adapter:
- Use of Delta Lake for all models out of the box
- SQL macros that are optimized to run with [Photon](https://docs.databricks.com/runtime/photon.html)

### Set up a Databricks Target
### Connecting to Databricks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would keep this as an h2 for consistency

Suggested change
### Connecting to Databricks
## Connecting to Databricks

### Set up a Databricks Target
### Connecting to Databricks

To connect to a data platform with dbt Core, create appropriate _profile_ and _target_ YAML keys/values in the `profiles.yml` configuration file for your Starburst/Trino clusters. This dbt YAML file lives in the `.dbt/` directory of your user/home directory. For more information, refer to [Connection profiles](/docs/core/connect-data-platform/connection-profiles) and [profiles.yml](/docs/core/connect-data-platform/profiles.yml).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericbaumann this references starburst and trino clusters -- is that correct?

Suggested change
To connect to a data platform with dbt Core, create appropriate _profile_ and _target_ YAML keys/values in the `profiles.yml` configuration file for your Starburst/Trino clusters. This dbt YAML file lives in the `.dbt/` directory of your user/home directory. For more information, refer to [Connection profiles](/docs/core/connect-data-platform/connection-profiles) and [profiles.yml](/docs/core/connect-data-platform/profiles.yml).
To connect to a data platform with dbt Core, create the appropriate _profile_ and _target_ YAML keys/values in the `profiles.yml` configuration file for your Starburst/Trino clusters. This dbt YAML file lives in the `.dbt/` directory of your user/home directory. For more information, refer to [Connection profiles](/docs/core/connect-data-platform/connection-profiles) and [profiles.yml](/docs/core/connect-data-platform/profiles.yml).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! good catch 👀


The following profile fields are always required.

| Field | Example | Description |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericbaumann not sure if it's just me but i wonder if it would be easier to have the columns set as 'field', 'description', and 'example'. I'm finding myself scanning to the description first before example so i can understand the 'thing'. happy to change this up for you if you agree

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a great idea! Feel like that will decrease the cognitive load we put on the reader. Thank you @mirnawong1 !!


dbt-databricks can connect to the Databricks SQL Warehouses and all-purpose clusters. Databricks SQL Warehouses is the recommended way to get started with Databricks.
#### Example profiles.yml for token-based authentication
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm wondering if this should be an h3 or h2 header? i also like the idea of using tabs so the user can switch between the two without much scrolling. if that makes sense, I'm happy to change this into tabs and share the preview.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is what you're referring to or not, but I was kinda questioning the side nav hierarchy after I saw the deploy preview. I feel like these should maybe be represented on there in some capacity (even if it's one link to the section for example profiles - totally defer to your judgment though.

I was also kind of wondering if it'd be appropriate to nest the '[...] Parameters' sections underneath the 'Configuring dbt-databricks' section. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea great shout! i'm going to make some edits if you're ok with that? and will share the deploy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds great, thanks mirna!!

@amychen1776 amychen1776 removed their request for review August 18, 2023 17:33
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mirnawong1 mirnawong1 merged commit ba24324 into current Aug 18, 2023
10 checks passed
@mirnawong1 mirnawong1 deleted the ebaumann/databricks-docs branch August 18, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants