Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SL fast follows, query link, and clarify primary entity #3896

Merged
merged 5 commits into from
Aug 9, 2023
Merged

SL fast follows, query link, and clarify primary entity #3896

merged 5 commits into from
Aug 9, 2023

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Aug 9, 2023 •
edited
Loading

this pr:

  • adds the sql query syntax link in key places like the migration guide, get started guide as well as the avail integrations page
  • clarifies language in get started pages
  • updates typos
  • adds contextual info wrt primary entity
    other nits as well.

@mirnawong1 mirnawong1 requested a review from a team as a code owner August 9, 2023 12:23
@netlify
Copy link

netlify bot commented Aug 9, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 2ba8bf2
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64d3bc98d505f5000864689f
😎 Deploy Preview https://deploy-preview-3896--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels Aug 9, 2023
@mirnawong1 mirnawong1 changed the title clarify sql query syntax and other fast follows SL fast follows, query link, and clarify primary entity Aug 9, 2023
Jstein77
Jstein77 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@Jstein77 Jstein77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mirnawong1
Update cumulative-metrics.md
2ba8bf2 
update type to cumulative
@mirnawong1 mirnawong1 merged commit 2fe7b37 into current Aug 9, 2023
10 checks passed
@mirnawong1 mirnawong1 deleted the mwong-sl-add-query-link branch August 9, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jstein77 Jstein77 Jstein77 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirnawong1 @Jstein77