Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sl-jdbc.md #3886

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Update sl-jdbc.md #3886

merged 5 commits into from
Aug 9, 2023

Conversation

rpourzand
Copy link
Contributor

I realized the examples in the jdbc api query table are missing single quotes! I added them

What are you changing in this pull request and why?

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

I realized the examples in the jdbc api query table are missing single quotes! I added them
@rpourzand rpourzand requested a review from a team as a code owner August 8, 2023 04:38
@welcome
Copy link

welcome bot commented Aug 8, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit e91361c
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64d39320fe7bae0009ff340d
😎 Deploy Preview https://deploy-preview-3886--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix. labels Aug 8, 2023
remove excess apostrophe
@mirnawong1
Copy link
Contributor

hey @rpourzand thanks for opening this up! i left some questions for other fields as they may not need apostrophes -- wanted to double check with you!

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Aug 9, 2023
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @rpourzand , looks good! approving to merge ✨ ! thanks for opening this up!

@mirnawong1 mirnawong1 merged commit 72b89de into current Aug 9, 2023
10 checks passed
@mirnawong1 mirnawong1 deleted the rpourzand-typo-in-jdbc-table branch August 9, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants