Update metrics-overview.md #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make table align with sample code
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
content
runleonarun
reviewed
Aug 7, 2023
| @@ -13,7 +13,10 @@ The keys for metrics definitions are: | |||
| | Component | Description | Type | | |||
| | --------- | ----------- | ---- | | |||
| | `name` | Provide the reference name for the metric. This name must be unique amongst all metrics. | Required | | |||
| | `type` | Define the type of metric, which can be a measure (`simple`) or ratio (`ratio`)). | Optional | | |||
| | `description` | Provide the description for your metric. | Optional | | |||
| | `configs` | Provide the specific configurations for your metric | Optional | | |||
There was a problem hiding this comment.
@dave-connors-3 I like this idea! Should we also move configs and label down below type_params?
mirnawong1
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
made those changes so the table matches the code - thanks for opening this up @dave-connors-3 ! ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make table align with sample code
What are you changing in this pull request and why?
table and sample code didn't match!
Checklist
Adding new pages (delete if not applicable):
website/sidebars.jsRemoving or renaming existing pages (delete if not applicable):
website/sidebars.jswebsite/static/_redirects