Merge pull request #321 from dbt-labs/hotfix--fix-tests-for-#308

[HOTFIX] fix tests for #308

CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## dbt-external-tables v0.10.0
+
+### Snowflake
+* Refactor create_external_table.sql in snowflake plugin by @kyleburke-meq in https://github.com/dbt-labs/dbt-external-tables/pull/318
+* stage_external_sources Comparing source_name of the node instead of the name of the node by @ward-resa in https://github.com/dbt-labs/dbt-external-tables/pull/312
+* added ignore_case for Snowflake by @cakkinep in https://github.com/dbt-labs/dbt-external-tables/pull/308
+
+## New Contributors
+* @ward-resa made their first contribution in https://github.com/dbt-labs/dbt-external-tables/pull/312
+
+**Full Changelog**: https://github.com/dbt-labs/dbt-external-tables/compare/0.9.0...0.10.0-b1
+
 ## dbt-external-tables v0.9.0
 
 ### Snowflake

integration_tests/models/plugins/snowflake/snowflake_external.yml

@@ -118,7 +118,7 @@ sources:
 
       - name: people_parquet_column_list_unpartitioned
         external: &parquet-people
-          location: '@{{ target.schema }}.dbt_external_tables_testing/parquet'
+          location: '@{{ target.schema }}.dbt_external_tables_testing/parquet/'
           file_format: '{{ target.schema }}.dbt_external_tables_testing_parquet'
         columns: *cols-of-the-people
         tests: *equal-to-the-people
@@ -206,11 +206,12 @@ sources:
       - name: people_parquet_infer_schema_ignore_case_unpartitioned
         external: 
           <<: *parquet-people
+          location: '@{{ target.schema }}.dbt_external_tables_testing/parquet_capitalized'
           infer_schema: true
           ignore_case: true
         tests:
           - dbt_utils.equality:
-              compare_model: ref('people_ignore_case')
+              compare_model: ref('people')
               compare_columns:
                 - id
                 - first_name
@@ -220,12 +221,13 @@ sources:
       - name: people_parquet_column_list_ignore_case_partitioned
         external: 
           <<: *parquet-people
+          location: '@{{ target.schema }}.dbt_external_tables_testing/parquet_capitalized'
           partitions: *parts-of-the-people
           ignore_case: true
         columns: *cols-of-the-people
         tests:
           - dbt_utils.equality:
-              compare_model: ref('people_ignore_case')
+              compare_model: ref('people')
               compare_columns:
                 - id
                 - first_name

integration_tests/package-lock.yml

@@ -0,0 +1,5 @@
+packages:
+  - local: ../
+  - package: dbt-labs/dbt_utils
+    version: 1.3.0
+sha1_hash: d412a8f2761befedebc730e6d5197956aec4fc9b

integration_tests/packages.yml

@@ -2,4 +2,4 @@
 packages:
   - local: ../
   - package: dbt-labs/dbt_utils
-    version: 0.8.0
+    version: 1.3.0

macros/plugins/snowflake/create_external_table.sql

@@ -4,11 +4,11 @@
     {%- set external = source_node.external -%}
     {%- set partitions = external.partitions -%}
     {%- set infer_schema = external.infer_schema -%}
-    {%- set ignore_case = external.ignore_case -%}
+    {%- set ignore_case = external.ignore_case or false  -%}
 
     {% if infer_schema %}
         {% set query_infer_schema %}
-            select * from table( infer_schema( location=>'{{external.location}}', file_format=>'{{external.file_format}}', ignore_case=>true) )
+            select * from table( infer_schema( location=>'{{external.location}}', file_format=>'{{external.file_format}}', ignore_case=> {{ ignore_case }}) )
         {% endset %}
         {% if execute %}
             {% set columns_infer = run_query(query_infer_schema) %}
@@ -19,6 +19,8 @@
 
 {# https://docs.snowflake.net/manuals/sql-reference/sql/create-external-table.html #}
 {# This assumes you have already created an external stage #}
+
+{% set ddl %}
     create or replace external table {{source(source_node.source_name, source_node.name)}}
     {%- if columns or partitions or infer_schema -%}
     (
@@ -83,4 +85,7 @@
     {% if external.integration -%} integration = '{{external.integration}}' {%- endif %}
     file_format = {{external.file_format}}
     {% if external.table_format -%} table_format = '{{external.table_format}}' {%- endif %}
+{% endset %}
+{# {{ log('ddl: ' ~ ddl, info=True) }} #}
+{{ ddl }};
 {% endmacro %}