Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/ParsedNode for seed node dup #11041

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix/ParsedNode for seed node dup #11041

wants to merge 1 commit into from

Conversation

JamesBonddu
Copy link

@JamesBonddu JamesBonddu commented Nov 24, 2024 •
edited
Loading

Resolves #11040

Problem

clean code, Remove Duplicate seedNode from ParsedNode

Solution

remove it

@JamesBonddu JamesBonddu requested a review from a team as a code owner November 24, 2024 10:45
@github-actions github-actions bot added the community This PR is from a community member label Nov 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@dbeatty10 dbeatty10 added Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes labels Nov 24, 2024
@dbeatty10
Copy link
Contributor

Good eyes @JamesBonddu -- looks like this logic was accidentally duplicated in #3364. Makes sense to remove the 2nd one.

@JamesBonddu
Copy link
Author

Good eyes @JamesBonddu -- looks like this logic was accidentally duplicated in #3364. Makes sense to remove the 2nd one.

THK, haha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community This PR is from a community member Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] ParsedNode for seed node dup
2 participants
@JamesBonddu @dbeatty10