Feature: Improve footer content #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrosio3
force-pushed
the
feature/footer
branch
2 times, most recently
from
48422fc
to
c8b767e
Compare
elizabethlofredo
approved these changes
Jun 28, 2022
| <VStack | ||
| w="100%" | ||
| justify="space-between" | ||
| flexDirection={['column-reverse', 'column-reverse', 'column']} |
There was a problem hiding this comment.
'column-reverse' twice here, is that correct?
There was a problem hiding this comment.
It's correct. The array syntax applies the first value until the sm breakpoint, the second value until the md breakpoint, and so on...
|
|
||
| import { MaxWidthWrapper } from '@components/Misc'; | ||
|
|
||
| import { FooterContainer } from './FooterContainer'; | ||
| import { LinksSection } from './LinksSection'; | ||
| import { LogosSection } from './LogosSection'; | ||
| import { NewsletterSection } from './NewsletterSection'; | ||
|
|
||
| export const Footer = () => ( |
There was a problem hiding this comment.
I think chakra-ui is already contemplating the accessibility part but this is an interesting example of an accessible Footer, you can take a look: https://a11y-style-guide.com/style-guide/section-navigation.html#kssref-navigation-navigation-footer
There you can see that is using the correct semantic for the Footer and the lists inside it.
There was a problem hiding this comment.
That's very helpful. It should be fixed now. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links:
What & Why:
Risks, Mitigation & Rollback: