-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Python wrapper #3
Open
grihabor
wants to merge
42
commits into
dbaranchuk:master
Choose a base branch
from
grihabor:python-wrapper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grihabor
force-pushed
the
python-wrapper
branch
from
September 18, 2018 12:00
6ecb8b2
to
766a332
Compare
Hi, Thanks for your contribution! I'll test your wrapper on real data at an early date. If everything is fine, I'll accept your request. |
I think, it's a good idea to split the pull request into 2 parts:
In addition to the python interface, please also check the library build |
grihabor
force-pushed
the
python-wrapper
branch
3 times, most recently
from
September 18, 2018 21:50
79eb50f
to
30e128f
Compare
grihabor
force-pushed
the
python-wrapper
branch
from
September 19, 2018 09:40
e953723
to
0e8c7f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I need some feedback on my python wrapper for your library.
Build and Install
Package uses setuptools extension interface, so it can be properly built and installed into virtualenv.
You need
g++
,make
,cmake
andswig
to be installed on your system.> python setup.py install
Try it out
This example is from
python-tests/
directoryPlans
I need to know if anyone really needs a fully working python interface.
Any help is appreciated!