Update README.md #17
Open
Update README.md #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelCurrin
approved these changes
Jun 30, 2020
okainov
reviewed
Jul 3, 2020
| 1. Fork it. (<https://github.com/yourname/yourproject/fork>) | ||
| 2. Create your feature branch. (`git checkout -b feature/fooBar`) | ||
| 3. Commit your changes. (`git commit -am 'Add some fooBar'`) | ||
| 4. Push to the branch. (`git push origin feature/fooBar`) |
There was a problem hiding this comment.
Why do you put full stop before parenthesis?
There was a problem hiding this comment.
Yes, if you want to dot those lines it should really be:
Text text (
…).
…or perhaps even better - commas, and a period on the last.
- Foo,
- Bar,
- Baz.
/2¢
There was a problem hiding this comment.
Parentheses are unneeded if it is split over lines. Keep the full stop.
Example code:
2. Create your feature branch.
```sh
git checkout -b feature/fooBar
```Result:
- Create your feature branch.
git checkout -b feature/fooBar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.