Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with floating label disables click #3608

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix: issue with floating label disables click #3608

merged 1 commit into from
Dec 17, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Dec 17, 2024

Proposed changes

Currently, the select won't open the options while clicking on the label: https://stackoverflow.com/questions/32653002/click-on-label-doesnt-open-select

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-floating-label-form-components

@github-actions github-actions bot added the 🏘components Changes inside components folder label Dec 17, 2024
@nmerget nmerget enabled auto-merge (squash) December 17, 2024 14:11
@nmerget nmerget disabled auto-merge December 17, 2024 14:11
@nmerget nmerget merged commit 07ec134 into main Dec 17, 2024
74 checks passed
@nmerget nmerget deleted the fix-floating-label-form-components branch December 17, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke Awaiting requested review from mfranzke mfranzke is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees
No one assigned
Labels
🏘components Changes inside components folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nmerget