Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(vite): esm build #3599

Merged
merged 5 commits into from
Dec 17, 2024
Merged

refactor(vite): esm build #3599

merged 5 commits into from
Dec 17, 2024

Conversation

mfranzke
Copy link
Member

Proposed changes

Prevent vite's build warning:

The CJS build of Vite's Node API is deprecated. See https://vite.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Dec 12, 2024
@mfranzke mfranzke self-assigned this Dec 12, 2024
@github-actions github-actions bot added the 🏘components Changes inside components folder label Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-esm-vite-build

@mfranzke
Copy link
Member Author

mfranzke commented Dec 13, 2024 •
edited
Loading

@nmerget should we proceed in migrating this package to type module, or just rename the vite fileending to .mjs?

Let's proceed with the simple renaming.

@mfranzke mfranzke marked this pull request as ready for review December 15, 2024 11:17
@mfranzke mfranzke enabled auto-merge (squash) December 15, 2024 11:17
@mfranzke mfranzke merged commit 961707f into main Dec 17, 2024
73 checks passed
@mfranzke mfranzke deleted the refactor-esm-vite-build branch December 17, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees

@mfranzke mfranzke

Labels
🏘components Changes inside components folder 🍄🆙improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfranzke @nmerget