Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: let's not make this rule deactivation too global #3589

Merged
merged 23 commits into from
Dec 18, 2024
Merged

refactor: let's not make this rule deactivation too global #3589

merged 23 commits into from
Dec 18, 2024

Conversation

mfranzke
Copy link
Member

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-do-we-need-this

@mfranzke mfranzke mentioned this pull request Dec 11, 2024
Merged
5 tasks
@mfranzke mfranzke changed the title Update generate-icon-overview.ts refactor: let's not make this rule deactivation too global Dec 11, 2024
Base automatically changed from fix-migration-tool to main December 11, 2024 14:19
@github-actions github-actions bot added the 🏗foundations Changes inside foundations folder label Dec 17, 2024
@mfranzke mfranzke enabled auto-merge (squash) December 17, 2024 11:44
@mfranzke mfranzke merged commit fcbd8d6 into main Dec 18, 2024
74 checks passed
@mfranzke mfranzke deleted the refactor-do-we-need-this branch December 18, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees
No one assigned
Labels
🏗foundations Changes inside foundations folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfranzke @nmerget