Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tabs): ensure valid tab id values #3530

Merged
merged 5 commits into from
Dec 18, 2024
Merged

refactor(tabs): ensure valid tab id values #3530

merged 5 commits into from
Dec 18, 2024

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Nov 28, 2024 •
edited
Loading

Proposed changes

We need to ensure that tabs only include a valid tab value, whereas the current implementation might start with e.g. a number.

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke
refactor(tabs): resilience for tab ID values
c22c8ce 
We need to ensure that tabs only includes a valid tab value, whereas the current implementation might start with e.g. a number.
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Nov 28, 2024
@mfranzke mfranzke self-assigned this Nov 28, 2024
@mfranzke mfranzke removed their assignment Nov 28, 2024
@mfranzke mfranzke enabled auto-merge (squash) November 28, 2024 18:52
@github-actions github-actions bot added the 🏘components Changes inside components folder label Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-tabs-resilience-for-tab-id-values

@mfranzke mfranzke changed the title refactor(tabs): resilience for tab ID values refactor(tabs): ensure valid tab ID values Nov 28, 2024
@mfranzke mfranzke changed the title refactor(tabs): ensure valid tab ID values refactor(tabs): ensure valid tab id values Nov 28, 2024
@nmerget
Copy link
Member

nmerget commented Nov 29, 2024

Shouldn't we do it for tab-panels as well?

@mfranzke
Copy link
Member Author

mfranzke commented Nov 29, 2024 •
edited
Loading

Shouldn't we do it for tab-panels as well?

@nmerget Probably I'm misunderstanding your comment, but what are you referring to? The change is related to the tab panel even already, isn't it?: https://github.com/db-ui/mono/pull/3530/files#diff-3105bc16411a04c3e4f14f688a286a069e40378e9a57b2f526b678f93b1831dfR131

@mfranzke mfranzke merged commit 61a1a88 into main Dec 18, 2024
72 checks passed
@mfranzke mfranzke deleted the refactor-tabs-resilience-for-tab-id-values branch December 18, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees
No one assigned
Labels
🏘components Changes inside components folder 🍄🆙improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfranzke @nmerget