Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rule optimization #3159

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor: rule optimization #3159

wants to merge 2 commits into from

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Sep 7, 2024 •
edited
Loading

Proposed changes

Deactivating a rule in total is quite heavy, we should only take care of specific aspects and probably define things a little bit more granular.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Sep 7, 2024
@mfranzke mfranzke added this to the v0.5.0 milestone Sep 7, 2024
@mfranzke mfranzke self-assigned this Sep 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 7, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-rule-optimization

@mfranzke mfranzke removed this from the v0.5.0 milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget will be requested when the pull request is marked ready for review nmerget is a code owner

@annsch annsch Awaiting requested review from annsch annsch will be requested when the pull request is marked ready for review annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch will be requested when the pull request is marked ready for review bruno-sch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mfranzke mfranzke

Labels
🍄🆙improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfranzke @nmerget